feat(files): folders, multiselect, vfs update by icecrasher321 · Pull Request #4572 · simstudioai/sim

icecrasher321 · 2026-05-12T21:45:34Z

Summary

Add folders, multiselect for files, update VFS to work with this.

Type of Change

New feature

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-05-12T21:45:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview, Comment	May 15, 2026 6:02pm

cursor · 2026-05-12T21:45:41Z

PR Summary

Medium Risk
Medium risk: adds new workspace file folder APIs (move/bulk delete/download) and refactors multiple existing routes to call orchestration helpers, which could change behavior/error mapping across files, workflows, schedules, credentials, and MCP server management.

Overview
Adds workspace file folders + multi-select operations: new APIs to create/list/update/delete/restore file folders, move and bulk-archive file/folder selections, and download selected files/folders as a capped ZIP; upload/presign/register flows now accept folderId, and internal file-manage tooling supports path-based folder creation plus a move operation.

Refactors several existing endpoints (credentials, folders, workflows, schedules jobs, tables/knowledge/workflow restore, and mcp server/tool routes) to delegate logic to perform* orchestration functions with standardized error-code-to-HTTP mapping, updating/adding tests accordingly.

Improves UI/accessibility by adding ModalDescription to multiple modals, and enhances the Resource table component with shift/meta selection support, optional row drag/drop hooks, leading header actions, and percentage-based column sizing; adds new files UI components for a floating selection action bar and delete confirmation modal.

^{Reviewed by Cursor Bugbot for commit 62393f2. Configure here.}

greptile-apps · 2026-05-12T21:51:10Z

Greptile Summary

This PR adds folder support and multiselect to the workspace files UI, introducing a new workspace_file_folders table, folder CRUD/move/restore API routes, a bulk-archive endpoint, a ZIP download endpoint, and updates the VFS to correctly group files under folder paths.

Schema: Adds workspace_file_folders with a self-referential FK (SET NULL on delete) and replaces the flat workspace-file unique-name constraint with a folder-scoped partial unique index.
API routes: New endpoints for folder CRUD (/folders, /folders/[folderId], /folders/[folderId]/restore), bulk archive (/bulk-archive), move (/move), and ZIP download (/download); advisory-lock transactions guard all mutation paths.
VFS: materializeFiles now embeds folder paths into VFS paths and returns folderPath as a separate field so buildWorkspaceMd grouping works correctly; archived file folders are surfaced in recently-deleted.

Confidence Score: 4/5

The change is broadly well-constructed; one route handler maps a new error thrown by the folder-validation helper to the wrong HTTP status code.

The register route now passes folderId to registerUploadedWorkspaceFile, which calls assertWorkspaceFileFolderTarget. When the folder has been deleted between the presign and register steps, that helper throws 'Target folder not found' — but the catch block only maps 'not found in storage' to 404, so this new error surfaces as a 500. Every other new route in this PR handles the same error class cleanly.

apps/sim/app/api/workspaces/[id]/files/register/route.ts — the catch block needs to cover the new 'Target folder not found' error path introduced by the folder-aware registration flow.

Important Files Changed

Filename	Overview
apps/sim/app/api/workspaces/[id]/files/register/route.ts	Added folderId passthrough to registerUploadedWorkspaceFile, but the catch block does not map the new 'Target folder not found' error to a 400/404 — instead it falls through to 500.
apps/sim/lib/uploads/contexts/workspace/workspace-file-folder-manager.ts	New core manager for workspace file folders; implements advisory-lock-protected transactions for create/move/archive/restore with well-structured path resolution via buildWorkspaceFileFolderPathMap.
apps/sim/app/api/workspaces/[id]/files/download/route.ts	New ZIP download endpoint with path deduplication, size/file-count guards, and sanitized zip paths; catch block correctly returns a hardcoded 'Internal server error'.
apps/sim/lib/workspace-files/orchestration/file-folder-lifecycle.ts	New orchestration layer for folder CRUD/move/restore operations with consistent typed-error-to-HTTP-code mapping; 23505 and domain error types all handled cleanly.
packages/db/schema.ts	Adds workspace_file_folders table with self-referential FK (SET NULL on delete), partial unique index on active folders, and replaces the workspace-scoped file name unique constraint with a folder-scoped one.
apps/sim/app/api/workspaces/[id]/files/move/route.ts	New move endpoint; delegates to performMoveWorkspaceFileItems which catches conflict/not-found/validation errors and maps them to correct HTTP status codes.
apps/sim/lib/copilot/vfs/workspace-vfs.ts	VFS now materializes files under folder-path prefixes and exposes folderPath as a separate field so buildWorkspaceMd grouping logic works correctly; archived file folders are also included in recently-deleted.

Comments Outside Diff (1)

apps/sim/app/api/workspaces/[id]/files/register/route.ts, line 90-100 (link)

Invalid folderId returns 500 instead of 400

registerUploadedWorkspaceFile now calls assertWorkspaceFileFolderTarget, which throws new Error('Target folder not found') when the folder ID doesn't exist or was deleted between the presign and register steps. The catch block only matches isMissing on 'not found in storage', so 'Target folder not found' falls through to status = 500, returning an internal error code for what is a client-supplied bad value. A status: 400 (or 404) with that message is the correct response here.

_{Reviews (18): Last reviewed commit: "fix mcp server error code" | Re-trigger Greptile}

icecrasher321 · 2026-05-12T22:23:53Z

@greptile

icecrasher321 · 2026-05-12T22:23:58Z

bugbot run

icecrasher321 · 2026-05-12T22:38:16Z

@greptile

icecrasher321 · 2026-05-12T22:38:20Z

bugbot run

icecrasher321 · 2026-05-12T23:52:18Z

@greptile

icecrasher321 · 2026-05-12T23:52:22Z

bugbot run

icecrasher321 · 2026-05-13T01:54:29Z

bugbot run

icecrasher321 · 2026-05-13T01:54:34Z

@greptile

icecrasher321 · 2026-05-13T02:10:52Z

bugbot run

icecrasher321 · 2026-05-13T02:10:59Z

@greptile

icecrasher321 · 2026-05-13T02:21:53Z

bugbot run

icecrasher321 · 2026-05-15T06:13:28Z

bugbot run

icecrasher321 · 2026-05-15T06:13:33Z

@greptile

icecrasher321 · 2026-05-15T06:30:50Z

bugbot run

icecrasher321 · 2026-05-15T06:30:53Z

@greptile

icecrasher321 · 2026-05-15T16:48:57Z

bugbot run

icecrasher321 · 2026-05-15T16:49:01Z

@greptile

icecrasher321 · 2026-05-15T17:10:08Z

bugbot run

icecrasher321 · 2026-05-15T17:22:05Z

bugbot run

icecrasher321 · 2026-05-15T17:22:19Z

@greptile

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 62393f2. Configure here.}

vercel Bot deployed to Preview May 12, 2026 21:49 View deployment

greptile-apps Bot reviewed May 12, 2026

View reviewed changes

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/files/files.tsx

Comment thread apps/sim/app/workspace/[workspaceId]/files/files.tsx

vercel Bot deployed to Preview May 12, 2026 22:24 View deployment

greptile-apps Bot reviewed May 12, 2026

View reviewed changes

Comment thread apps/sim/lib/uploads/contexts/workspace/workspace-file-folder-manager.ts Outdated

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/files/files.tsx

Comment thread apps/sim/hooks/queries/workspace-file-folders.ts

Comment thread apps/sim/lib/uploads/client/download.ts Outdated

vercel Bot temporarily deployed to Preview May 12, 2026 22:38 Inactive

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts Outdated

greptile-apps Bot reviewed May 12, 2026

View reviewed changes

Comment thread apps/sim/lib/uploads/contexts/workspace/workspace-file-folder-manager.ts

Comment thread apps/sim/app/api/workspaces/[id]/files/folders/[folderId]/route.ts

vercel Bot temporarily deployed to Preview May 12, 2026 23:51 Inactive

cursor Bot reviewed May 13, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/files/files.tsx

Comment thread apps/sim/app/api/workspaces/[id]/files/download/route.ts

Comment thread apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts Outdated

vercel Bot temporarily deployed to Preview May 13, 2026 01:54 Inactive

cursor Bot reviewed May 13, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/files/files.tsx

Comment thread apps/sim/app/workspace/[workspaceId]/files/files.tsx Outdated

Comment thread apps/sim/app/api/workspaces/[id]/files/download/route.ts

vercel Bot temporarily deployed to Preview May 13, 2026 02:10 Inactive

cursor Bot reviewed May 13, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/files/files.tsx

Comment thread apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts

vercel Bot temporarily deployed to Preview May 13, 2026 02:21 Inactive

greptile-apps Bot reviewed May 15, 2026

View reviewed changes

Comment thread apps/sim/app/api/workspaces/[id]/files/download/route.ts